FIXUP: CHROMIUM: virtwl: add virtwl driver
0day reports:
drivers//virtio/virtio_wl.c: In function do_send:
drivers//virtio/virtio_wl.c:790:9: warning:
ret may be used uninitialized in this function [-Wmaybe-uninitialized]
BUG=chromium:738638
TEST=Build driver with W=1
Change-Id: I83afb8b7e754bd80e660ec772671a20a87df5624
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/802255
Reviewed-by: Dylan Reid <dgreid@chromium.org>
diff --git a/drivers/virtio/virtio_wl.c b/drivers/virtio/virtio_wl.c
index 0e3159d..da84ab3 100644
--- a/drivers/virtio/virtio_wl.c
+++ b/drivers/virtio/virtio_wl.c
@@ -710,7 +710,6 @@
struct virtio_wl_ctrl_vfd_send *ctrl_send;
__le32 *vfd_ids;
u8 *out_buffer;
- unsigned long remaining;
struct completion finish_completion;
struct scatterlist out_sg;
struct scatterlist in_sg;
@@ -763,9 +762,10 @@
for (i = 0; i < vfd_count; i++)
vfd_ids[i] = cpu_to_le32(vfds[i]->id);
- remaining = copy_from_user(out_buffer, buffer, len);
- if (remaining)
+ if (copy_from_user(out_buffer, buffer, len)) {
+ ret = -EFAULT;
goto free_ctrl_send;
+ }
init_completion(&finish_completion);
sg_init_one(&out_sg, ctrl_send, sizeof(*ctrl_send) + post_send_size);
