| commit | 433296f8802ccf82eb32da3bfa002df2a8b5095a | [log] [tgz] |
|---|---|---|
| author | Andy Chu <andychu@google.com> | Sat Mar 19 23:11:30 2016 -0700 |
| committer | Rob Landley <rob@landley.net> | Thu Apr 14 21:30:24 2016 -0500 |
| tree | f6d98eeab74343cb31a0d9ff67ef07d447f00944 | |
| parent | c73947814aab381a0761ecc919e6c5407c3fd617 [diff] |
Fix a buffer overflow in diff -r. We were doing two 32-byte memset()s instead of two 16-byte memset()s. 'dir' referred to the instance (array of 2) and not the struct type. Add some test coverage for diff, including a case that hit this bug. The bug was found by running cp.test under AddressSanitizer, since it happens to use diff.