tree 4dce860a2e4a886e5d2bbed3a44a8215e5ebe42c
parent 7b1bfbc0786fdc9ba511d0136f6417736bdc4cc6
author Jan Blunck <j.blunck@tu-harburg.de> 1124828714 +0200
committer Chris Wright <chrisw@osdl.org> 1125334513 -0700

[PATCH] sg.c: fix a memory leak in devices seq_file implementation (2nd)

I know that scsi procfs is legacy code but this is a fix for a memory leak.

While reading through sg.c I realized that the implementation of
/proc/scsi/sg/devices with seq_file is leaking memory due to freeing the
pointer returned by the next() iterator method. Since next() might
return NULL or an error this is wrong. This patch fixes it through using
the seq_files private field for holding the reference to the iterator
object.

Here is a small bash script to trigger the leak. Use slabtop to watch
the size-32 usage grow and grow.

#!/bin/sh

while true; do
	cat /proc/scsi/sg/devices > /dev/null
done

Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de>
Signed-off-by: Chris Wright <chrisw@osdl.org>