tree d5ee11e647116774edbf2cfc46182acfb3c12700
parent 15d258674b5c91b9c1ae11264624d5c0d0675e8f
author Johannes Thumshirn <jthumshirn@suse.de> 1533044761 +0200
committer Martin K. Petersen <martin.petersen@oracle.com> 1533238203 -0400

scsi: fcoe: fix use-after-free in fcoe_ctlr_els_send

KASAN reports a use-after-free in fcoe_ctlr_els_send() when we're sending a
LOGO and have FIP debugging enabled. This is because we're first freeing
the skb and then printing the frame's DID. But the DID is a member of the
FC frame header which in turn is the skb's payload.

Exchange the debug print and kfree_skb() calls so we're not touching the
freed data.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>