commit 1865a9c382ede507065cf1575308b53495814c7d
author Kulikov Vasiliy <segooon@gmail.com> Sat Jul 31 21:40:07 2010 +0400
committer Greg Kroah-Hartman <gregkh@suse.de> Mon Aug 23 20:50:17 2010 -0700
tree 91e448411ba4a1b8478814253f20ecb8d56a2737
parent 6d4d4554863b7897f2bc9cd9085f54c819152825

USB: adutux: fix misuse of return value of copy_to_user()

copy_to_user() returns number of not copied bytes, not error code.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/misc/adutux.c

diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
index d240de0..801324a 100644
--- a/drivers/usb/misc/adutux.c
+++ b/drivers/usb/misc/adutux.c
@@ -439,7 +439,7 @@
 			/* drain secondary buffer */
 			int amount = bytes_to_read < data_in_secondary ? bytes_to_read : data_in_secondary;
 			i = copy_to_user(buffer, dev->read_buffer_secondary+dev->secondary_head, amount);
-			if (i < 0) {
+			if (i) {
 				retval = -EFAULT;
 				goto exit;
 			}